Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip exit module + regen catalogs #155

Merged
merged 13 commits into from
May 16, 2024
Merged

Skip exit module + regen catalogs #155

merged 13 commits into from
May 16, 2024

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented May 1, 2024

Fixes #153

Also

  • fixes handling of parameter in group with same name as other parameter.
  • For less clicking for user., when node has single collapsible field it is expanded initially.

Copy link

netlify bot commented May 1, 2024

Deploy Preview for i-vresse-workflow-builder ready!

Name Link
🔨 Latest commit 6d48844
🔍 Latest deploy log https://app.netlify.com/sites/i-vresse-workflow-builder/deploys/6645cffef4670800078f4511
😎 Deploy Preview https://deploy-preview-155--i-vresse-workflow-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sverhoeven
Copy link
Member Author

Getting "Error: Can not have group and un-grouped parameter with same name restraints" from https://github.com/i-VRESSE/workflow-builder/blob/no-exit/packages/core/src/grouper.ts#L49

lightdock has restraints group and restraints parameter which is in another group (distance restraints).
Need to make grouper smarter.

@sverhoeven sverhoeven merged commit 549bde0 into main May 16, 2024
5 checks passed
@sverhoeven sverhoeven deleted the no-exit branch May 16, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the exit module in workflow builder
1 participant